Fix stream caching in _CachedRequest #3093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuyugama
force-pushed
the
kh/fix/CachedRequest-stream-caching
branch
from
ec38679 to
6b279e1
Compare
kuyugama
force-pushed
the
kh/fix/CachedRequest-stream-caching
branch
from
6b279e1 to
d26acf4
Compare
Owner
|
Can you give me an MRE that shows the problem? |
Author
|
I'm going to bed rn, so a bit later. To be clear I was just reading source code and noticed it, so I don't have MRE prepared. |
Author
|
It seems, that there's no problem with this, so I am closing this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that
_CachedRequestatstarlette.middleware.basehad uncompletestream()generator caching (_wrapped_rc_stream), so I fixed thatChecklist
I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
I've updated the documentation accordingly.